Allow fetching lints from registries #87
Assignees
Labels
A-marker-cargo
Area: All things connected to `cargo_marker`
C-enhancement
Category: New feature or request
Comments
xFrednet
added
C-enhancement
This was referenced Jan 11, 2023
|
It might be worth to check out the |
bors bot
added a commit
that referenced
this issue
May 7, 2023
126: cargo-marker: add git support r=xFrednet a=Niki4tap
Its been a while since I've worked on this, but I've finally took the time to finish it.
This PR adds git support to marker so this now works:
```toml
[workspace.metadata.marker.lints]
marker_lints = { git = "https://github.com/rust-marker/marker" }
```
It makes use of [`cargo_fetch`](https://github.com/Niki4tap/cargo_fetch) library which I made for this specific use-case, which is essentially just a thin wrapper around `cargo` library (so the builds are now way slower :p).
I'll try to maintain the library to my best capacity, and prioritize marker's goals whenever needed.
Addition of the library also technically allows for any kind of package to be downloaded, so this also *technically* supports registries, though this PR does not implement it, because this is blocked on marker APIs being released.
---
In total this checks out... *\*looks up the issue\**... one task from #81!
But also *technically* closes <!-- do not close this issue github please --> #87 whenever APIs are published.
review side note: most changes are from `Cargo.lock`
Co-authored-by: Niki4tap <rombiklol2@gmail.com>
bors bot
added a commit
that referenced
this issue
May 7, 2023
126: cargo-marker: add git support r=xFrednet a=Niki4tap
Its been a while since I've worked on this, but I've finally took the time to finish it.
This PR adds git support to marker so this now works:
```toml
[workspace.metadata.marker.lints]
marker_lints = { git = "https://github.com/rust-marker/marker" }
```
It makes use of [`cargo_fetch`](https://github.com/Niki4tap/cargo_fetch) library which I made for this specific use-case, which is essentially just a thin wrapper around `cargo` library (so the builds are now way slower :p).
I'll try to maintain the library to my best capacity, and prioritize marker's goals whenever needed.
Addition of the library also technically allows for any kind of package to be downloaded, so this also *technically* supports registries, though this PR does not implement it, because this is blocked on marker APIs being released.
---
In total this checks out... *\*looks up the issue\**... one task from #81!
But also *technically* closes <!-- do not close this issue github please --> #87 whenever APIs are published.
review side note: most changes are from `Cargo.lock`
Co-authored-by: Niki4tap <rombiklol2@gmail.com>
xFrednet
added
A-marker-cargo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#81 adds support to specify lint crates in
Cargo.tomlfiles. For now only local paths and git repositories are allowed. In the future, registries likecrates.ioshould also be allowed.This issue is currently blocked until the first version of
marker_apihas been released to crates.io, as we're otherwise not able to upload a lint crate to crates.io. It might be possible to work around this restriction by defining a git dependency. 🤔 I'll still mark it as blocked for now.The text was updated successfully, but these errors were encountered: