ndk-build,cargo-apk: Default target_sdk_version to 30 or lower
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Nov 22, 2021
cargo-apk/CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Unreleased | |||
|
|
|||
| - **Breaking**: Default `target_sdk_version` to `29` or lower for more consistent | |||
| interaction with Android backwards compatibility and tighter rules: | |||
There was a problem hiding this comment.
Not a fan of this wording, will see if I can come up with something better after a night's sleep.
There was a problem hiding this comment.
Updated. @msiglreith what do you think?
|
I think you misread the page (which is because it's not properly updated), because it says:
So the correct level to use by default is 30, not 29, since we are now after August. And yes, that does have scoped storage implications - it enforces it on Android 11 and 12, and you need to opt out to not get enforced on Android 10 as well. |
|
Thanks for pointing that out. Indeed, that page literally starts out with:
Hence the confusion. Will update this. |
MarijnS95
force-pushed
the
target-sdk-version
branch
from
523ffb1
to
7446268
Compare
MarijnS95
changed the title
target_sdk_version to 29 or lowertarget_sdk_version to 30 or lower
msiglreith
approved these changes
Nov 24, 2021
msiglreith
reviewed
Nov 24, 2021
MarijnS95
force-pushed
the
target-sdk-version
branch
from
023d56a
to
0bd3db8
Compare
As discussed in [197] setting `target_sdk_version` to the "arbitrary" highest available SDK version is nonsense. This target version (unlike `min_sdk_version` which defines the least set of symbols that should be available) has real impact on the runtime of an application, in particular the compatibility or stringency of rules Android applies to your application. Certain APIs may not work at all or be heavily restricted on newer target versions because they are deemed too dangerous, and Android expects the user has tested their app against these limitations and is communicating this by setting `target_sdk_version` to that particular value. Hence this shouldn't change purely based on the environment, even for the default. To retain some backwards compatibility with previous `cargo-apk` we set this to level 30 which is the least [required by Google Play] today, and exactly what users will have been targeting using NDK r22 (assuming the SDK for this `platform` was installed as well) since SDK version 31 support with NDK r23 only [arrived just last week]. [197]: #197 (comment) [required by Google Play]: https://developer.android.com/distribute/best-practices/develop/target-sdk [arrived just last week]: #189
MarijnS95
force-pushed
the
target-sdk-version
branch
from
0bd3db8
to
8a93ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #197
As discussed in 197 setting
target_sdk_versionto the "arbitrary" highest available SDK version is nonsense. This target version (unlikemin_sdk_versionwhich defines the least set of symbols that should be available) has real impact on the runtime of an application, in particular the compatibility or stringency of rules Android applies to your application. Certain APIs may not work at all or be heavily restricted on newer target versions because they are deemed too dangerous, and Android expects the user has tested their app against these limitations and is communicating this by settingtarget_sdk_versionto that particular value. Hence this shouldn't change purely based on the environment, even for the default.To retain some backwards compatibility with previous
cargo-apkwe set this to level 30 which is the least required by Google Play today, and exactly what users will have been targeting using NDK r22 (assuming the SDK for thisplatformwas installed as well) since SDK version 31 support with NDK r23 only arrived just last week.Thanks @hrydgard for bringing this to my attention!