cargo-apk: Reimplement NDK r23 -lgcc workaround using RUSTFLAGS
#270
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mercesa
approved these changes
May 11, 2022
|
Lgtm. Believe it was solved via the library search path in xbuild too |
You seem to have solved this there by emitting the |
|
And yes, all arguments are chained into a EDIT: It seems xbuild uses |
|
It works on my machine, tested it locally. Solves the problems we were having with |
msiglreith
approved these changes
May 11, 2022
Any flags passed directly to `cargo rustc` will only be passed _to the final compiler invocation_. However `cdylib` library targets in transitive (dependency) crates will still be built (despite not being used in the final binary, that's what `rlib`s are for), but our NDK r23 workaround flags will not reach these compiler invocations rendering b912a6b ("cargo-apk: Work around missing libgcc on NDK r23 with linker script (#189)") ineffective. [The same page] that documents this discrepancy suggests to resort to `RUSTFLAGS` if arguments are intended for all compiler invocations, which is our intended use-case and unblocks builds with transitive `cdylib` dependencies such as `hyper` in [#265]. [The same page]: https://doc.rust-lang.org/cargo/commands/cargo-rustc.html#description [#265]: #265
MarijnS95
force-pushed
the
global-lgcc-workaround
branch
from
8bfeee5
to
4aa11ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265, CC @Mercesa
Any flags passed directly to
cargo rustcwill only be passed to the final compiler invocation. Howevercdyliblibrary targets in transitive (dependency) crates will still be built (despite not being used in the final binary, that's whatrlibs are for), but our NDK r23 workaround flags will not reach these compiler invocations rendering b912a6b ("cargo-apk: Work around missing libgcc on NDK r23 with linker script (#189)") ineffective.The same page that documents this discrepancy suggests to resort to
RUSTFLAGSif arguments are intended for all compiler invocations, which is our intended use-case and unblocks builds with transitivecdylibdependencies such ashyperin #265.