Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nostr: complete NIP51 #344

Merged
merged 18 commits into from
Mar 14, 2024
Merged

nostr: complete NIP51 #344

merged 18 commits into from
Mar 14, 2024

Conversation

rustedmoon
Copy link
Contributor

Description

Complete NIP51

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@rustedmoon rustedmoon force-pushed the nip51 branch 2 times, most recently from b26ba6a to 3b62565 Compare March 7, 2024 15:57
@yukibtc yukibtc added this to the Release v0.29 milestone Mar 7, 2024
@yukibtc yukibtc linked an issue Mar 7, 2024 that may be closed by this pull request
Add NIP51 constructors to EventBuilder and missing related Kind #272
Closed
@yukibtc yukibtc removed this from the Release v0.29 milestone Mar 11, 2024
@rustedmoon rustedmoon marked this pull request as ready for review March 14, 2024 10:54
yukibtc
yukibtc requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some more docs (ex. link the NIP51) in structs and constructors/methods?

yukibtc
yukibtc approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@yukibtc yukibtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 11da1fa

@yukibtc yukibtc merged commit 11da1fa into rust-nostr:master Mar 14, 2024
6 checks passed
@rustedmoon rustedmoon deleted the nip51 branch April 3, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dluvian dluvian dluvian left review comments

@yukibtc yukibtc yukibtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NIP51 constructors to EventBuilder and missing related Kind
3 participants
@rustedmoon @yukibtc @dluvian