Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigint: Create the parsing error better for nested + #269

Merged
merged 2 commits into from
Mar 8, 2017
Merged

bigint: Create the parsing error better for nested + #269

merged 2 commits into from
Mar 8, 2017

Commits on Mar 6, 2017

  1. bigint: Cleanup unused imports

    @cuviper
    cuviper committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    4b8c71f View commit details
    Browse the repository at this point in the history

  2. bigint: Create the parsing error better for nested + 

    If a `+` is encountered in the middle of parsing a BigUint, this should
generate an `ParseIntError::InvalidDigit`.  Since we can't create that
directly, we get it by trying to parse a `u64` from this point, but of
course `+` is a perfectly valid prefix to a `u64`.

Now we include the previous character in the string passed to `u64`, so
it has proper parsing context to understand what's in error.

Fixes rust-num#268.
    @cuviper
    cuviper committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    0b6cae0 View commit details
    Browse the repository at this point in the history