Skip to content

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Nov 8, 2025

Lets use https://crates.io/docs/trusted-publishing to not require local crates.io keys.

@dhardy dhardy requested a review from tarcieri November 8, 2025 10:04
@dhardy dhardy mentioned this pull request Nov 8, 2025
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to setup the GitHub environment (I did it now). You also need to update the crate settings.

@newpavlov
Copy link
Member

Do we also want a GitHub release job similar to rand_core?

@dhardy
Copy link
Member Author

dhardy commented Nov 9, 2025

You forgot to setup the GitHub environment

Should it be using v* tags instead of the master branch?

Do we also want a GitHub release job similar to rand_core?

Personally I don't care much (or even if we make GH releases at all). For a new PR anyway.

@newpavlov
Copy link
Member

Should it be using v* tags instead of the master branch?

Ideally, we would use an AND condition, but, unfortunately, IIUC GitHub does not currently support them. So I think publishing from the master branch is a more important restriction.

Personally I don't care much (or even if we make GH releases at all)

I feel the same. But it would be nice to be consistent with other crates in the org (i.e. we should add GH release job for all repos or remove it from rand_core).

@dhardy dhardy merged commit 2b30d01 into master Nov 10, 2025
75 checks passed
@dhardy dhardy deleted the push-ulmnplwxvssm branch November 10, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants