Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ToXml public #134

Open
Pajn opened this issue Jan 29, 2022 · 4 comments
Open

Make ToXml public #134

Pajn opened this issue Jan 29, 2022 · 4 comments

Comments

@Pajn
Copy link

Pajn commented Jan 29, 2022

Would it be possible to either make the toxml module public or add a pub use crate::toxml::ToXml to lib.rs?

@andy128k
Copy link
Member

May you elaborate why this may be needed?

@Pajn
Copy link
Author

Pajn commented Jan 30, 2022

I want to encode individual items to xml. I'm subscribing to an RSS feed and will do a bunch of data processing on each item. I need to store the input for followup and possible reprocessing.
I could do that by pulling everything out to a struct of my own and use serde, however as from_xml is already public on individual items it feels natural that the libray would allow me to du the mirror operation on individual items as well.

@andy128k
Copy link
Member

I think that from_xml was made public mistakenly. It should be pub(crate).

@Asone
Copy link

Asone commented Feb 4, 2023

A small bump to agree with the request of this issue.

I'm pretty sure many use case that involves replication of partial content of the RSS feeds would benefit from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants