run black on PR and fix formatting issues in autogenerate_pipeline.py

[stefano-garzarella]

Summary of the PR

The last commit made black unhappy.
Let's fix the formatting issues suggested by black and run it on every PR to avoid this issue in the future.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

• All commits in this PR have Signed-Off-By trailers (with
  git commit -s), and the commit message has max 60 characters for the
  summary and max 75 characters for each description line.
• All added/changed functionality has a corresponding unit/integration
  test.
• All added/changed public-facing functionality has entries in the "Upcoming
  Release" section of CHANGELOG.md (if no such section exists, please create one).
• Any newly added unsafe code is properly documented.

[roypat]

oh, I just noticed that we actually have a black github action. But why does it run after merge instead of on PRs? :o Should we change

rust-vmm-ci/.github/workflows/black.yaml

Line 2 in 752ad13

push:

to be on: pull_request instead? 🤔

[stefano-garzarella]

oh, I just noticed that we actually have a black github action. But why does it run after merge instead of on PRs? :o Should we change

rust-vmm-ci/.github/workflows/black.yaml

Line 2 in 752ad13

push:

to be on: pull_request instead? 🤔

I was going to ask, I'm pretty sure I already fixed some other issue in the past years, and maybe asked the same, but didn't find anything.

[roypat]

oh, I just noticed that we actually have a black github action. But why does it run after merge instead of on PRs? :o Should we change

rust-vmm-ci/.github/workflows/black.yaml

Line 2 in 752ad13

push:

to be on: pull_request instead? 🤔

I was going to ask, I'm pretty sure I already fixed some other issue in the past years, and maybe asked the same, but didn't find anything.

Ahhh, yeah, now I see. I completely misunderstood you on the other issue last year, sorry! Let's just move this github action to run on PRs instead of post-merge then. I really don't see a good reason why we shouldnt (we check formatting pre-merge on all other repos after all), and it already caused it to have to do fix up PRs at least twice now

[stefano-garzarella]

@roypat yeah, I'm going to add a commit to this PR

[TimePrinciple]

Should we wait until this is merged, and then upgrade kvm-bindings's CI? I saw the version bump on kvm-bindings is about to be merged

[stefano-garzarella]

Should we wait until this is merged, and then upgrade kvm-bindings's CI? I saw the version bump on kvm-bindings is about to be merged

This is just a fix for a formatting issue, so IMHO it doesn't really matter.

[stefano-garzarella]

Just rebased since our CI on main is still red, @andreeaflorescu @lauralt @sameo @ShadowCurse please, can you take a look?