riscv64: Fix VM network #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `nameserver` from `8.8.8.8` to `10.0.2.3` as QEMU User Networking (SLIRP)[1] documents. [1] https://wiki.qemu.org/Documentation/Networking Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
TimePrinciple
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat and
ShadowCurse
as code owners
|
This fix is verified in 
Detailed log is here. Thanks for @stefano-garzarella's help ❤️, addresses exactly where the problem is. |
stefano-garzarella
approved these changes
Sep 6, 2024
roypat
approved these changes
Sep 6, 2024
TimePrinciple
added a commit
to TimePrinciple/rust-vmm-ci
that referenced
this pull request
Sep 6, 2024
This version includes a fix [1] on network problem of riscv64 QEMU VM. [1] rust-vmm/rust-vmm-container#116 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
4 tasks
TimePrinciple
added a commit
to TimePrinciple/rust-vmm-ci
that referenced
this pull request
Sep 6, 2024
This version includes a fix [1] on network problem of riscv64 QEMU VM. [1] rust-vmm/rust-vmm-container#116 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
stefano-garzarella
pushed a commit
to rust-vmm/rust-vmm-ci
that referenced
this pull request
Sep 6, 2024
This version includes a fix [1] on network problem of riscv64 QEMU VM. [1] rust-vmm/rust-vmm-container#116 Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Change
nameserverfrom8.8.8.8to10.0.2.3as QEMU User Networking (SLIRP)[1] documents.[1] https://wiki.qemu.org/Documentation/Networking
Which addresses the network problem when cargo tries to fetch packages from
index.crates.io.Fixes: rust-vmm/kvm-bindings#106
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.