Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw ERROR instead of WARN when source can't be sanitized #1082

Open
Schweber opened this issue Feb 26, 2024 · 2 comments
Open

Throw ERROR instead of WARN when source can't be sanitized #1082

Schweber opened this issue Feb 26, 2024 · 2 comments
Labels
A-cli Area: `rustic` command line interface A-commands Area: Related to commands in `rustic` A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected

Comments

@Schweber
Copy link

Schweber commented Feb 26, 2024

This is not a bug per se but unexpected behaviour for me:

I run rustic as a systemd service with an on-failure dependency that alerts me to errors. However, rustic hasn't been doing backups for a while because i removed one of the backup source directories so it stopped with [WARN] error sanitizing source="...

As this is a WARN and not an ERROR, my systemd service didn't throw an error and i wasn't alerted to the fact, that no backups were being made.

I would like rustic to throw an ERROR when a backup doesn't succeed for any reason. Either as default behaviour or as an option/flag. This would be important for me for unattended use of rustic.

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Feb 26, 2024
@aawsome
Copy link
Member

aawsome commented Feb 26, 2024

@Schweber Thanks for opening the issue!
I also think we should improve error handling. For backup there are many cases for warnings

However, note that #927 (which in fact means that even in error cases rustic currently doesn't return an error code) is still open. Until this is fixed, systemd's OnFailure doesn't work independent from how we classify errors...

@aawsome aawsome added C-bug Category: Something isn't working as expected A-cli Area: `rustic` command line interface A-commands Area: Related to commands in `rustic` A-ui-ux Area: Related to user interfaces and user experience and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Feb 26, 2024
@Schweber
Copy link
Author

Oh sorry, i overlooked this issue. Thank you for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: `rustic` command line interface A-commands Area: Related to commands in `rustic` A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants