Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Format" job in CI is too slow #645

Closed
briansmith opened this issue Apr 15, 2021 · 1 comment · Fixed by #811
Closed

"Format" job in CI is too slow #645

briansmith opened this issue Apr 15, 2021 · 1 comment · Fixed by #811

Comments

@briansmith
Copy link
Contributor

According to https://github.com/ctz/rustls/actions/runs/753327095 this job takes 7 minutes. I'm guessing that's because building it from source is slow. We should consider using the GitHub Actions cache feature to cache the resultant binary.

It is very annoying to wait 7+ minutes and only then find out that I forgot to run admin/fmt, and then have to wait another 7+ minutes.

@djc
Copy link
Member

djc commented Apr 16, 2021

Once rust-lang/rustfmt#4782 lands, I think we can just use a pre-built nightly rustfmt (and stable in 3 months or so). Before that happens, I'm not very motivated to fix this. Another potential workaround could be to set up a pre-commit git hook that runs admin/fmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants