Improve the Fetch API #188
Conversation
crates/fetch/src/lib.rs
Outdated
| /// | ||
| /// If you are going to insert new headers, note that | ||
| /// [some names are forbidden](https://developer.mozilla.org/en-US/docs/Glossary/Forbidden_header_name) | ||
| /// and if they are set then sending the request will error. |
There was a problem hiding this comment.
Need to check the spec to see what happens, it's possible the offending headers are silently discarded.
|
Have you seen reqwasm? If not, please have a look. It tries to be exactly what you're PRing and then some. |
Cool! your crate mostly superseeds my work, but there are a couple of points where I've done more (e.g. doc comments from MDN). It would be good to get |
…oo-reqwasm This merge is done to move reqwasm crate to gloo. This puts reqwasm under the gloo umbrella. See #188 (comment) for need of this merge.
|
I have created #191 Once that is merged, I encourage you to update your branch to build off of it. One big improvement I can see is documentation: your docs are much better. |
|
Yep happy to rebase off of your patch, which will make this PR mostly docs. :) |
|
I have merged the PR. You can rebase now |
|
@derekdreery any update on this? Are you working on the rebase? |
|
Yes apologies I've been busy with work. Don't want to make promises but will look at ASAP. |
# Conflicts: # crates/net/Cargo.toml # crates/net/README.md # crates/net/src/http.rs
|
I went ahead and merged master into this branch |
|
Thanks for doing this - sorry I haven't had time. |
I needed a fetch interface, and I didn't find any of the existing options exactly fit my needs (I needed access to some of the web-only options), so I implemented it in
gloo.The implementation tries to be as unopinionated as possible, just doing things like strongly typing results, and discarding impossible errors. I'm PRing it in case you're interested in having it upstream, but I'm also happy to just keep a private fork if you don't want it.