Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history: Fix required feature set of serde dependency #357

Merged
merged 2 commits into from
Jul 23, 2023

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jul 23, 2023

The state module uses Serialize and Deserialize as derive macros, but those are only available with the derive feature.

Also simplify some cfg expressions in the same crate.

The state module uses Serialize and Deserialize as derive macros, but
those are only available with the derive feature.
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

I think most of the time the derive feature is enabled by a downstream crate already, so we never caught this on our side.

@futursolo futursolo merged commit ff19d20 into rustwasm:master Jul 23, 2023
@jplatte jplatte deleted the jplatte/history-serde-derive branch July 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants