Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal to support single inheritance and casting in wasm-bindgen #2

Merged
merged 4 commits into from
Aug 7, 2018
Merged

Proposal to support single inheritance and casting in wasm-bindgen #2

merged 4 commits into from
Aug 7, 2018

Commits on Jul 19, 2018

  1. Proposal to support single inheritance and casting in wasm-bindgen

    @fitzgen
    fitzgen committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    a8bfb29 View commit details
    Browse the repository at this point in the history

  2. Update based on RFC comment thread discussions 

    * Use `From` and `As{Ref,Mut}` instead of custom upcasting trait. Allows
  upcasting multiple steps at a time and is more familiar.

* Introduce arbitrary unchecked casting escape hatch.

* Some refactoring of dynamic casts (and unchecked casts) into the `JsCast`
  trait.
    @fitzgen
    fitzgen committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    6c9b1cf View commit details
    Browse the repository at this point in the history

  3. show the generated JS for instanceof checks

    @fitzgen
    fitzgen committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    f2d92aa View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. Merge JsCast and InstanceOf traits 

    And rename `try_{into,ref,mut}` to `dyn_{into,ref,mut}` to be future compatible
with `TryFrom`.
    @fitzgen
    fitzgen committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    3b5a38d View commit details
    Browse the repository at this point in the history