Update template index to run "Hello world!" #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation doesn't seem to run the function that was exported from Rust, `main_js()`. At first, I thought this was intentional, but the [current docs](https://github.com/rustwasm/wasm-pack/blob/master/docs/src/tutorials/hybrid-applications-with-webpack/using-your-library.md) which are out of date and say that a `run()` function should be here. I'll add a link to my change to the docs here shortly.
epompeii
added a commit
to epompeii/wasm-pack
that referenced
this pull request
Aug 13, 2020
The documentation is out of date. It says that there should be a `run()` function, but really a `main_js()` function should be there. However, the `rust-webpack-template` doesn't add the `then()` statement to the import in the template. I have created [a pull request](rustwasm/rust-webpack-template#172) to add this to the template, and I have updated the docs for this newer version here.
|
The pull request for the documentation change is wasm-pack Issue #899. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't seem to run the function that was exported from Rust,
main_js().At first, I thought this was intentional, but the current docs which are out of date and say that a
run()function should be here.I'll add a link to my change to the docs here shortly.