Initial support for Document, EventTarget, NodeList and Iterator

[jonathanKingston]

@alexcrichton https://github.com/rustwasm/wasm-bindgen/compare/master...jonathanKingston:web-sys/document-support?expand=1#diff-9f9955b41f2425125eaf42c53a05c94dR558 is the mentioned issue from #514 (comment)

The other question I had was surrounding: element.query_selector_all('x').get(0) returning a Node not an Element. Is this something rustwasm/rfcs#2 will tackle?

[alexcrichton]

Awesome, thanks for this!

I've switched the throws there to false and I think I see the issue! The first problem is that Option wasn't defined in this list. After that though it looked like the path traversal code wasn't handling generics so there were lots of compilations errors. After filling out the missing cases though it should be all good to go!

[alexcrichton]

I wasn't quite sure what these two methods were doing, is this what it means to be iterable? (a values and an item method?)

[jonathanKingston]

It comes from the iterable in webidl yeah: https://heycam.github.io/webidl/#es-iterable

I couldn't get forEach to work as we don't have callbacks yet.

entries, keys and values and some other behaviour is needed.

I messed up though item is a getter on the webidl which isn't supported yet.

[jonathanKingston]

Thanks for this direction, it really helped me understand the codebase a lot more too!

[jonathanKingston]

I filled in the Parenthesized PathArguments and it looks like it is working (I have more in Element now like getAttribute which wasn't working before).

I commented out the code for now as I think I need to implement a trait for iterator similar to how OptionFromWasmAbi and OptionIntoWasmAbi work.

I think perhaps I could remove the function comments and it should be merged as is (without iterator).

[alexcrichton]

I think so yeah if you get a chance, makes sense to go ahead and add it here!

[alexcrichton]

Awesome looks great to me!

Do you think we'll need a new trait for the iterator types? I'm actually curious if we can get by with an Iterator trait implementation? Or perhaps things like values return impl Iterator?

[jonathanKingston]

Wow cool thanks for merging!

Do you think we'll need a new trait for the iterator types? I'm actually curious if we can get by with an Iterator trait implementation? Or perhaps things like values return impl Iterator?

More experimenting needed I think, I am hoping we can use that but I'm still learning here.

[alexcrichton]

Sure thing! I'm all for incremental changes anyway :)