From fc8937defeb2ff929b950e72644409f5b9b1b118 Mon Sep 17 00:00:00 2001 From: Ruud Kamphuis Date: Sun, 14 Feb 2021 09:32:17 +0100 Subject: [PATCH] Add failing test fixture for RenameMethodRector # Failing Test for RenameMethodRector Based on https://getrector.org/demo/38775b0b-7f57-4f18-97ac-b39a71fa6d78 It should detect that the old method is not public and that the new magic method `__invoke` can only be applied when public. # The commit message #2 will be skipped: # xx --- ...> skip_rename_private_method_to_private_invoke.php.inc} | 2 +- .../RenameMethodRector/config/configured_rule.php | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) rename rules/renaming/tests/Rector/MethodCall/RenameMethodRector/Fixture/{skip_private_method_rename_to_private_invoke.php.inc => skip_rename_private_method_to_private_invoke.php.inc} (75%) diff --git a/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/Fixture/skip_private_method_rename_to_private_invoke.php.inc b/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/Fixture/skip_rename_private_method_to_private_invoke.php.inc similarity index 75% rename from rules/renaming/tests/Rector/MethodCall/RenameMethodRector/Fixture/skip_private_method_rename_to_private_invoke.php.inc rename to rules/renaming/tests/Rector/MethodCall/RenameMethodRector/Fixture/skip_rename_private_method_to_private_invoke.php.inc index 400a6dcec516..a633f025b054 100644 --- a/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/Fixture/skip_private_method_rename_to_private_invoke.php.inc +++ b/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/Fixture/skip_rename_private_method_to_private_invoke.php.inc @@ -2,7 +2,7 @@ namespace Rector\Renaming\Tests\Rector\MethodCall\RenameMethodRector\Fixture; -final class SkipPrivateMethodRenameToPrivateInvoke +final class SkipRenamePrivateMethodToPrivateInvoke { private function notify() { diff --git a/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/config/configured_rule.php b/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/config/configured_rule.php index fec33b2818b8..1c6c7f2f5f53 100644 --- a/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/config/configured_rule.php +++ b/rules/renaming/tests/Rector/MethodCall/RenameMethodRector/config/configured_rule.php @@ -3,6 +3,7 @@ use Nette\Utils\Html; use Rector\Renaming\Rector\MethodCall\RenameMethodRector; use Rector\Renaming\Tests\Rector\MethodCall\RenameMethodRector\Fixture\SkipPrivateMethodRenameToPrivateInvoke; +use Rector\Renaming\Tests\Rector\MethodCall\RenameMethodRector\Fixture\SkipRenamePrivateMethodToPrivateInvoke; use Rector\Renaming\Tests\Rector\MethodCall\RenameMethodRector\Source\AbstractType; use Rector\Renaming\ValueObject\MethodCallRename; use Rector\Renaming\ValueObject\MethodCallRenameWithArrayKey; @@ -20,11 +21,7 @@ 'notify', '__invoke' ), - new MethodCallRename( - 'Rector\Renaming\Tests\Rector\MethodCall\RenameMethodRector\Fixture\SkipPrivateMethodRenameToPrivateInvoke', - 'notify', - '__invoke' - ), + new MethodCallRename(SkipRenamePrivateMethodToPrivateInvoke::class, 'notify', '__invoke'), new MethodCallRename('*Presenter', 'run', '__invoke'), new MethodCallRename( \Rector\Renaming\Tests\Rector\MethodCall\RenameMethodRector\Fixture\SkipSelfMethodRename::class,