Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are the query* methods still used? #20

Open
nebrius opened this issue Nov 19, 2018 · 1 comment
Open

Are the query* methods still used? #20

nebrius opened this issue Nov 19, 2018 · 1 comment

Comments

@nebrius
Copy link
Contributor

nebrius commented Nov 19, 2018

I was going over the spec for my Abstract IO class and comparing with the Raspi IO implementation, and I noticed that queryCapabilities, queryAnalogMapping, and queryPinState are not mentioned in the docs. Are these methods still used and need to be added to the spec, or can they be dropped from Raspi IO?
@nebrius
Copy link
Contributor Author

nebrius commented Nov 20, 2018

I think I answered my own question: these methods exist in firmata.js, but are not used in Johnny-Five, and so I think it's safe to say that we don't need to include these in the IO Plugin protocol. I'm open to counter-arguments though. Primarily, do we care about the IO Plugin spec being 100% compatible with firmata.js or are we okay with it being a subset?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nebrius