Do not require SERIAL_PORT_IDs.Default

Addresses rwaldron/tessel-io#23
rwaldron · Apr 5, 2019 · c8d4f07 · c8d4f07
1 parent 5d0dc72
commit c8d4f07
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/gps.js b/lib/gps.js
@@ -142,8 +142,6 @@ function GPS(opts) {
     this, opts = Board.Options(opts)
   );
 
-
-
   // Get user values for breakout, receiver and chip
   breakout = opts.breakout || {};
   receiver = opts.receiver;
@@ -265,7 +263,13 @@ util.inherits(GPS, events.EventEmitter);
 GPS.prototype.initialize = function(opts) {
 
   var state = priv.get(this);
-  state.portId = opts.serialPort || opts.portId || opts.port || opts.bus || this.io.SERIAL_PORT_IDs.DEFAULT;
+  state.portId = opts.serialPort || opts.portId || opts.port || opts.bus;
+
+  // firmata.js has a SERIAL_PORT_IDs.DEFAULT that is not 
+  // necessary in other IO plugins so it won't always exist. 
+  if (typeof state.portId === "undefined" && this.io.SERIAL_PORT_IDs) {
+    state.portId = this.io.SERIAL_PORT_IDs.DEFAULT;
+  }
 
   // Set the pin modes
   ["tx", "rx"].forEach(function(pin) {