Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace src/logger.rs with slog-rs #152

Closed
mehcode opened this issue Jan 23, 2017 · 1 comment
Closed

Replace src/logger.rs with slog-rs #152

mehcode opened this issue Jan 23, 2017 · 1 comment
Labels
duplicate This issue or pull request already exists question A question (converts to discussion) request Request for new functionality

Comments

@mehcode
Copy link
Contributor

mehcode commented Jan 23, 2017

https://github.com/slog-rs/slog
https://github.com/slog-rs/slog#advantages-over-log-crate

Thoughts? Structured logging out of the box would be a big win for Rocket. As it stands now I would need to disable Rocket logging and implement a Responder I use on every resource (should I open a tracking issue for Middleware) that logs how I want it to log.
@SergioBenitez
Copy link
Member

There are tracking issues for both of these ideas/questions. See #21 and #55.

@SergioBenitez SergioBenitez added duplicate This issue or pull request already exists question A question (converts to discussion) request Request for new functionality labels Jan 23, 2017
@mehcode mehcode closed this as completed Jan 23, 2017
@pwoolcoc pwoolcoc mentioned this issue Dec 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists question A question (converts to discussion) request Request for new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehcode @SergioBenitez