Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mutual authentication over TLS #254

Closed
SergioBenitez opened this issue Apr 13, 2017 · 6 comments
Closed

Support mutual authentication over TLS #254

SergioBenitez opened this issue Apr 13, 2017 · 6 comments
Labels
enhancement A minor feature request

Comments

@SergioBenitez
Copy link
Member

Rocket will support client authentication over TLS. This is a tracking issue.
@SergioBenitez SergioBenitez added the enhancement A minor feature request label Apr 13, 2017
@SergioBenitez SergioBenitez added this to the 0.4.0 milestone Apr 13, 2017
@SergioBenitez SergioBenitez mentioned this issue Apr 13, 2017
Closed
@SergioBenitez SergioBenitez modified the milestones: 0.5.0, 0.4.0 Jul 2, 2017
@Kmoneal
Copy link

Kmoneal commented Dec 20, 2017

I am looking at implementing MTLS for a project that uses Rocket and wanted to know if I could be pointed in the right direction to start making these modification.

@SergioBenitez SergioBenitez modified the milestones: 0.5.0, 0.4.0 Jul 23, 2018
@SergioBenitez
Copy link
Member Author

Looks like this will make it in for 0.4, thanks to @Kmoneal and @akuanti. Track progress in #657.

@SergioBenitez
Copy link
Member Author

Ah, unfortunately spoke to soon. Pushing to 0.5, though this could also be in a 0.4 point release.

@SergioBenitez SergioBenitez modified the milestones: 0.4.0, 0.5.0 Sep 17, 2018
@dani-garcia dani-garcia mentioned this issue Jan 13, 2020
Closed
@SergioBenitez
Copy link
Member Author

This is held up in the PR queue. Removing it as a milestone until further progress.

@SergioBenitez SergioBenitez removed this from the 0.5.0 milestone Aug 6, 2020
@faulesocke
Copy link

Can I somehow help with implementing this?

@SergioBenitez
Copy link
Member Author

@faulesocke The latest effort is at #1419. Feel free to ping the author and/or takeover.

Note that whatever implementation we go with, it must have the property that MTLS can be enabled and disabled per-route, via a request guard, as well as optionally for the entire application, likely via a fairing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A minor feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SergioBenitez @faulesocke @Kmoneal