Skip to content

Commit

Permalink
Remove gitter-sidecar
Browse files Browse the repository at this point in the history 
[why]
Disfunctional

See PR #1252
  • Loading branch information
@rszyma @Finii
rszyma authored and Finii committed May 27, 2023
1 parent 288eed5 commit 34cddad
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 17 deletions.
10 changes: 0 additions & 10 deletions _includes/css/nerd-font-tweaks.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -286,16 +286,6 @@ a.nerd-font-button:before {
z-index: 12;
}

/* gitter chat tweaks */
.gitter-open-chat-button {
border-color: #2e2e2e;
color: #2e2e2e;
border-width: 2px 2px 0px 2px;
border-style: solid;
font-weight: bold;
font-family: Raleway;
}

/* HACK - replicate FA stack */
.fa-stack {
display: inline-block;
Expand Down
7 changes: 0 additions & 7 deletions _includes/scripts.html
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
<script async defer src="https://buttons.github.io/buttons.js"></script>
<script>
((window.gitter = {}).chat = {}).options = {
room: 'ryanoasis/nerd-fonts'
};
</script>
<script src="https://sidecar.gitter.im/dist/sidecar.v1.js" async defer></script>
<script src="site.js"></script>

This comment has been minimized.

Sign in to view

Copy link
@SilverMira

SilverMira May 27, 2023

Why was site.js removed? Currently https://www.nerdfonts.com/cheat-sheet is broken and no icons are showing

This comment has been minimized.

Sign in to view

Copy link
@Finii

Finii May 27, 2023

Collaborator

Thanks for the info, checking...

This comment has been minimized.

Sign in to view

Copy link
@rszyma

rszyma May 27, 2023 •
edited
Loading

Author Contributor

Ah, site.js should not be removed alone. It was meant to be removed along with the changes in #1252. My bad for splitting the commits wrong.

This comment has been minimized.

Sign in to view

Copy link
@Finii

Finii May 27, 2023

Collaborator

Fixed! Thanks for reporting!
Did not check if the commit was really self-contained.

This comment has been minimized.

Sign in to view

Copy link
@Finii

Finii May 27, 2023

Collaborator

@allcontributors please add @SilverMira for bug
<script type="application/ld+json">
{
"@context" : "http://schema.org",
Expand Down

1 comment on commit 34cddad

@rszyma
Copy link
Contributor Author

@rszyma rszyma commented on 34cddad May 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes:

It's no longer working since gitter fully migrated to Matrix.
(Even if you try other still working CDN for the sidecar, an error in js console will appear that gitter don't allow iframes from foreign domains, or something like that).
You can see there that gitter haven't yet implemented sidecar for Matrix. There's this issue being tracked for sidecar-like feature for Matrix-based gitter.

Please sign in to comment.