Retain glyph names when merging

[eugenesvk]

I've noticed that glyph names are lost when patching fonts. For example, if I take the Octicons font as a source of glyphs and patch another font with it (with the --octicons option), then all the glyph names (e.g. octoface or mark-github or repo-forked for some of the standard GitHub glyphs) are lost and instead replaced by Unicode glyph codes (e.g. uniF008 for octoface).

Is there a chance to retain those names? They are very useful in finding specific glyph codes (remembering a name is much easier than remembering a code, especially since codes can change between font versions, while name is usually more stable).
Thank you!

[ryanoasis]

@eugenesvk

I think I have found a solution to this 😄, I will include this with the next release if it tests out well. Thanks for reporting this 👍

somewhat related (in that info is lost): #43

[eugenesvk]

Ok, thanks a lot! Will be looking forward to it.
By the way, I've noticed another thing - some of the glyphs in the end of Octicons are not appended (e.g. F0E0 for 'watch' or F27C for 'device-desktop). I've downloaded the latest version before embedding (which has a few extra glyphs), so my guess would be that the address range is not updated yet. If that is the case, would you kindly update the range to for the --octicons option so that all glyphs get embedded?
Thanks!

P.S.
Never used github before, so not sure whether I should close this issue myself or you will do it after you release an update.

[ryanoasis]

@eugenesvk

Yes you are correct Octicons I am using is not up to date, see: #34 (comment)

No worries I was actually late to the GitHub party as well 😄 . For this issue we can leave it open and I will close it on the next release.

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.