https://github.com/caskroom/homebrew-fonts

[kevinSuttle]

Would love to be able to install the fonts in this repo via
https://github.com/caskroom/homebrew-fonts cc @phinze

[ryanoasis]

Sounds interesting, been busy so just no replying 😅

[jrolfs]

I definitely have had my eye on that as well. They don't seem too particular over there as there are quite a few Powerline patched fonts in master already but I figured it would be worth waiting until 0.7.0 until we start making PRs to Homebrew Fonts.

[kevinSuttle]

👍🏼

[ryanoasis]

I have created a shell script to create the casks 😄 in 0.9.0 but not sure how to test them without being on macOS 😢

Also not sure if these are even supposed to work without the source being an archive file.. anyone know? I will try to ask for some help on the homebrew fonts 😄

[kevinSuttle]

Ping @vitorgalvao

[vitorgalvao]

They don't seem too particular over there

We’re not.

but not sure how to test them without being on macOS

Travis can do it. Submit one of them (the most typical) and ping me. I’ll look into into it and see what it requires. If needed, you may then revise your script (rinse and repeat).

Also not sure if these are even supposed to work without the source being an archive file

You mean you have links to the naked ttf or otf? Not a problem, it works the same.

[vitorgalvao]

Almost forgot, the thing we’re particular about is the naming. See the docs.

[jrolfs]

I'm happy to help test this on a Mac although it sounds like getting it working on CI would be preferable.

@vitorgalvao does it make sense for all of the names to include a nerd-font suffix or the like since there will most likely be conflicts for all them seeing as they are patched versions of existing fonts? The other solution would be to use the pseudonym for the patched font that is used in this repo (eg: source-code-pro ➡ sauce-code-pro) which once patched would theoretically be the canonical name according to the Caskroom-fonts README:

• font-sauce-code-pro-nerd-font (original with suffix)
• font-source-code-pro-nerd-font (post-patch name with suffix)
• font-sauce-code-pro (post-patch name without suffix)

Also, there are multiple patch variants – I'm assuming you probably would prefer we don't contribute too much noise but only submitting the "complete" patch variant? Otherwise it would have to be something like:

• font-[canonical name]-complete
• font-[canonical name]-minimal

... maybe ...

• font-[canonical name]-plus-pomicons
• font-[canonical name]-plus-octicons
• font-[canonical name]-plus-font-awesome-plus-octicons

... etc.

/cc @ryanoasis

[vitorgalvao]

When casks have conflicting tokens, we add a prefix, not a suffix. But those names in your screenshot seem acceptable. If the font itself as Nerd Font in the name, adding that as a suffix to the cask makes sense.

And yes, if you could submit something as complete as possible (i.e. with the few number of casks as possible), that would be preferable.

[ryanoasis]

@kevinSuttle Thanks for pinging the appropriate people in 😊

You mean you have links to the naked ttf or otf? Not a problem, it works the same.

Yes. I think right now the download URL points to the main folder but then each individual font stanza points to each a subdirectory for each font family for that font.

@jrolfs For the patch variants except for "complete" I have removed the generating of those going forward. So yeah we will only create casks for the "complete" variations as well 😄

@vitorgalvao Thanks for replying and providing some more info. I actually did read the contributing docs and it really helped me build some test casks 😄 . That being said I could probably go through and read it again a bit more thoroughly 😛 .

1. Would it be acceptable to submit you something "complete" for just one font for now (e.g., Hack)?
2. By 'submit' I assume you mean a WIP PR or some other means until it is ironed out?

@jrolfs @vitorgalvao I am using fc-query in the script currently to help build the name to use.

@jrolfs If you have time and want you can actually run the script to see how I am currently generating the cask for 'Hack'. I am not able to run it currently and have not pushed the example it generates

Thanks all.

[vitorgalvao]

1. Would it be acceptable to submit you something "complete" for just one font for now (e.g., Hack)?
2. By 'submit' I assume you mean a WIP PR or some other means until it is ironed out?

Yes on both counts.

[ryanoasis]

If some one wants to test this... Hack (Knack) should now be available 😄 but seems like it should work just fine (ref: Homebrew/homebrew-cask-fonts#913)

---

Will submit one more individual font PR before submitting the rest. The rest is dependent on #32 (we have a script to generate the archives but not done with the upload/release script -- surely don't want to upload them manually)

[jrolfs]

Working for me, though do we actually need Mono?

[ryanoasis]

@jrolfs Thanks for testing it out

Working for me, though do we actually need Mono?

Good question. Well I do know there is a fair number that prefer or have to use mono in their terminal. I think maybe we could create a separate one for mono. something like font-hack-nerd-font and font-hack-mono-nerd-font.

--

Does anyone else have a strong preference regarding including variable width and mono together in the same cask?

My gut says to keep it as is but perhaps take it up in the next release because I feel this release is fairly large and long going already 😛

[ryanoasis]

@vitorgalvao Do you see any preference regarding this:

I think maybe we could create a separate one for mono. something like font-hack-nerd-font and font-hack-mono-nerd-font.

[vitorgalvao]

@ryanoasis No preference.

[ryanoasis]

Thanks

[gwerbin]

Would it make more sense to maintain a separate Tap for these? It might be easier than dumping them all in the core fonts repo.

(I wish the Powerline patched variants were in a separate Tap as well but that's not something I have the power to change at this point...)

[github-actions]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.