-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Netwide Assembler (NASM) icon #857
Comments
Related:
|
https://github.com/Peltoche/lsd/blob/master/src/icon.rs That icon comes from Seti UI & Custom. Well, I would not call I see no consensus of assembler programmers for one specific icon, and the lack of a real icon for nasm does increase the impression they themselves do not count the two-balls thing relevant as 'this is asm' indicator. The idea is good, but when I'm working with asm files and this icon turns up, I would think it a bug? |
I agree on that. I didn't thought about the similarity with Lua's icon, which is actually an embedded language so it wouldn't be too crazy to appear in a same codebase. I can bring some better alternatives: This one would be consistent with C and C++ ones and since the text is 3 letters only one would be able to distinguish it well enough These two goes for a completely different route, suggesting the language operating on the CPU What do you think about this ones? |
I must admit I think it looks quite good 😬 |
Thanks @Finii! I will figure out how to create a PR and link the issue |
Some hints are in https://github.com/ryanoasis/nerd-fonts/blob/master/contributing.md#contributing-guide The link in our documentation is broken I just noticed, it is https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github You need to turn your attention to the files in (The font rebuild via github action can also be 'imitated' on your local machine, by running :-) 👍 |
@Finii I just opened a PR. I'm not that experienced neither with Git nor this project so if there is any mistake please tell me so I can improve for my next contribution. I wasn't able to use FontForge to verify, it would show me almost no icons. |
[what] Adds consistance with other low level languages icons like C/C++. Reverted the change on `asm.svg`, added `asm_nf.svg`, modified `icons.tsv` [note] Closes #857. Closes [990#pullrequestreview-1171459043](#990 (review)) Signed-off-by: igna_martinoli <ignamartinoli@protonmail.com> [Note by Fini: Squashed two commits.] Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[what] Adds consistance with other low level languages icons like C/C++. Reverted the change on `asm.svg`, added `asm_nf.svg`, modified `icons.tsv` [note] Closes ryanoasis#857. Closes [990#pullrequestreview-1171459043](ryanoasis#990 (review)) Signed-off-by: igna_martinoli <ignamartinoli@protonmail.com> [Note by Fini: Squashed two commits.] Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Requirements
Is your feature request related to a problem? Please describe.
It would just be a nice add-on
Describe the solution you'd like
It would be cool to have an icon for Assembly languages for
nvim-web-devicons
andexa
to useDescribe alternatives you've considered
I don't know any other solution
Additional context
There is no icon nor mascot for Assembly
.asm
files in general, but Netwide Assembler is quite popular and with its icon could fit that spotThe text was updated successfully, but these errors were encountered: