Sunset in-repo releases #1360
Merged
Sunset in-repo releases #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] We struggle with the pack-committing of patched fonts to the repository on release. This makes our repo grow extremely big. It would be better to just use release artifacts for the releases and not commit any patched font back. There were different approaches discussed, but the problem remains that I personally have no rights to implement anything of that - neither can I force push to the default branch, nor can I create new repos in the organization. [how] To make it still possible to add new fonts without a repo size explosion we do not release NEW fonts back to the repository as commits, but old fonts are handled as before. NEW fonts: * have a new property set in the fonts.yaml 'database' * are released as release artifact via release workflow (but not committed back) * get a readme in the patched_fonts/ directory that points to the release artifact page The solution is not ideal, but for sure better than not adding any fonts anymore or having the repo grow in size faster and faster. At some point in time I would like to phase out all in-repo releases, also for OLD fonts. This scheme has been (manually) used / introduced for Intel One. With this change the .gitignore file is automatically adapted to any new font that is added with the repoRelease flag set to false (which should be the default for any added font from now on). Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
dragonmaus
added a commit
to dragonmaus/termux-styling
that referenced
this pull request
Mar 24, 2024
Fetch script updated to handle the upstream sunsetting of in-repo releases (ryanoasis/nerd-fonts#1360). The script will now fetch the tarball and extract the appropriate file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
We struggle with the pack-committing of patched fonts to the repository on release. This makes our repo grow extremely big. It would be better to just use release artifacts for the releases and not commit any patched font back.
There were different approaches discussed, but the problem remains that I personally have no rights to implement anything of that - neither can I force push to the default branch, nor can I create new repos in the organization.
[how]
To make it still possible to add new fonts without a repo size explosion we do not release NEW fonts back to the repository as commits, but old fonts are handled as before.
NEW fonts:
fonts.yaml'database'patched_fonts/directory that points to the release artifact pageThe solution is not ideal, but for sure better than not adding any fonts anymore or having the repo grow in size faster and faster.
At some point in time I would like to phase out all in-repo releases, also for OLD fonts.
This scheme has been (manually) used / introduced for Intel One. With this change the
.gitignorefile is automatically adapted to any new font that is added with therepoReleaseflag set tofalse(which should be the default for any added font from now on).Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Push to fork repository and let the action run there.
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)