Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inconsolata to v3.000 #775

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Update Inconsolata to v3.000 #775

merged 1 commit into from
Oct 7, 2022

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Jan 31, 2022

Description

Update Inconsolata to current release v3.000.

https://github.com/googlefonts/Inconsolata

Only small changes visually, but of course completely different from the
paths (because now the source is a 2D variable font).

Small letter t changed a bit.
Under the letter dot and block-building glyphs changed.
Subscript numerals.

Requirements / Checklist

What does this Pull Request (PR) do?

Update source font files.
Update generated files.

How should this be manually tested?

Any background context you can provide?

Discussion #774

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii
Copy link
Collaborator Author

Finii commented Jan 31, 2022

This does not include all the new widths and weights.
This PR includes only bold and regular, and so it just updates but does not expand.

It also does not touch the very old InconsolataGo and Inconsolata LGC that we also have...

@ryanoasis
Copy link
Owner

Now that the github action is rebuilding the fonts on merging to master I think we should change font updates and new font PRs to not actually update the patched-fonts/ directory and let that happen in the pipeline instead. I think just a spot check by a user is sufficient going forward. I'd see this as a welcome change but not sure what everyone else thinks

@Finii
Copy link
Collaborator Author

Finii commented Feb 6, 2022

I'd see this as a welcome change but not sure what everyone else thinks

In my opinion this is an excellent change, as with this we exactly know that the patched font in the repo is the same as we would create, and not some user patched it with an older font-patcher or did some manual adjustments afterwards. Manual changes might be helpful sometimes, but the knowledge about them will be lost (or be nonexisting if not mentioned in the PR).

One small drawback is that you can not immediately see the patch results. One possible solution would be this:

  • On (any) PR the workflow is run (on changed fonts)
  • But without back-commiting of the patched fonts (as this will be impossible in the general case)
  • Only the artifacts for changed fonts will be generated
  • If a change for font-patcher is PRed there are no changed fonts, this is ok I believe (-> no artifacts, needs exhaustive testing anyway)
  • If a font is added or changed that fonts are patched and artifacts generated for them

For this to work we need to find out which font files are changed and which are already up-to-date in the repo. This might be tricky, but doable.

Finii added a commit that referenced this pull request Feb 6, 2022
This reverts commit 85d4783.

[why]
The patched fonts will be re-created by the git workflow anyhow and just
make rebasing harder.

[note]
Because the actual font NAMES change, this is not just an update of
files, but obsolete files need to be removed. I'm not sure the workflow
manages to do that.

This has to be checked!

Example:
old: patched-fonts/CascadiaCode/Bold/complete/Caskaydia Cove Bold Nerd Font Complete.otf
new: patched-fonts/CascadiaCode/Bold/complete/Caskaydia Cove Nerd Font Complete Bold.otf

FontParser generates the name like this:
BasicFontname "Nerd Font" PatchSpecifyer Weight

Before FontParser the unpatched name has been taken and just all the
stuff added to the end, resulting in this:
BasicFontname Weight "Nerd Font" PatchSpecifyer

Which is not 'the standard way' to name a font.

[note]
#775 (comment)
@Finii Finii mentioned this pull request Feb 6, 2022
5 tasks
https://github.com/googlefonts/Inconsolata

Only small changes visually, but of course completely different from the
paths (because now the source is a 2D variable font).

Small letter t changed a bit.
Under the letter dot and block-building glyphs changed.
Subscript numerals.

Closes: #774

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii force-pushed the feature/update-inconsolata branch from 178f7a8 to 696c0ed Compare October 7, 2022 06:20
@Finii
Copy link
Collaborator Author

Finii commented Oct 7, 2022

Remove patch-artifacts, rebase on master, force push.

@Finii
Copy link
Collaborator Author

Finii commented Oct 7, 2022

Why is the SVG workflow triggered? This is a bug?
This PR does not touch any relevant files.
Maybe because I force pushed, so all the commits since the OLD master are considered?

image

@Finii Finii merged commit 25d8c0d into master Oct 7, 2022
@Finii Finii deleted the feature/update-inconsolata branch October 7, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants