feat: use standard Docker build Actions, enable builds for ARM architecture #985

sammcj · 2022-10-27T21:26:20Z

Description

Refactor docker-release (aka build and push) workflow to use the standard Docker Github Actions.

Requirements / Checklist

Read the Contributing Guidelines
Verified the license of any newly added font, glyph, or glyph set

What does this Pull Request (PR) do?

This adds the following features:

Builds for both AMD64 and ARM64 (other architectures can be enabled if required).
Automatic tagging and labelling (including 'latest').

How should this be manually tested?

I don't have access to your Docker hub credentials so wasn't able to test I could publish as your user, just check it does successfully publish with your creds the first time (but it should be fine!).

Any background context you can provide?

I went to run the nerd-fonts patcher and found the provided container image was only built for AMD64, many modern computers are ARM64 hence this PR.

https://github.com/marketplace/actions/build-and-push-docker-images

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii

Thank you for this nice PR.

First I had a deja vu feeling, but that was #882 (comment)

I will just pull as is, and see if the docker is still working on my machine (i.e. amd64).

Finii · 2022-10-28T04:55:27Z

.github/workflows/docker-release.yml

+ uses: docker/build-push-action@v3
+ with:
+ context: .
+ push: ${{ github.event_name != 'pull_request' }}


Suggested change

push: ${{ github.event_name != 'pull_request' }}

push: true

Because the whole workflow is not triggered on pull requests.

Finii · 2022-10-28T04:57:48Z

.github/workflows/docker-release.yml

+ id: meta
+ uses: docker/metadata-action@v4
+ with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}


Suggested change

github-token: ${{ secrets.GITHUB_TOKEN }}

I think this is not needed.

[why] Credentials not needed (I guess). Workflow is never run on pull-requests, so no check needed. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2022-10-28T09:43:21Z

Had a small problem that meta tags it as master but we always tagged as latest.
Solved with 1322285

Tried patching with the docker on amd64 and it works.

@sammcj Can you confirm arm64 please?

(Interestingly the image size did not really increase.)

Finii · 2022-10-28T10:06:36Z

Hmm, looking here, I see only amd64 and no arm64 ?

@sammcj Any ideas? I am a docker noob.

sammcj · 2022-10-28T12:44:01Z

Hey sorry just saw this it's midnight here but I'll fork the repo, create a docker hub account and test it out using my own token. Feel free to temporarily revert if it's causing any issues!

Finii · 2022-10-28T17:26:03Z

Ah, I managed to create the arm thing 🎉

via commit
df58a78 CI: Entice docker to create arm64 container [skip ci]

But maybe you can try to patch a font with that. And report which fontforge version it has?

sammcj · 2022-10-29T02:40:19Z

ooohhhh I didn't release it needed the platform there as well! Good spotting and thanks!

I'll be testing it out shortly.

sammcj · 2022-10-29T03:16:06Z

Seems to work fine, only error is about iconv encoding - but that won't be ARM build related.

I've run the patched fonts through font book and they validated without issue.

macOS 13.0
Apple Macbook Air (m1)

1.006; ttfautohintv1.8.3;Nerd Fonts 2.3.0-RC

docker run -v /Users/samm/Downloads/Atkinson_Hyperlegible:/in -v /Users/samm/Downloads/Atkinson_Hyperlegible-nerd:/out nerdfonts/patcher
Running with options:

Internal Error: Your version of iconv does not support the "Mac Roman" encoding.
If this causes problems, reconfigure --without-iconv.
Copyright (c) 2000-2022. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20220308
 Based on sources from 2022-07-24 20:58 UTC-D.
 Based on source from git with hash: 3714b0323943afc54607f9404b672ca469364cb3
The truetype encoding specified by platform=1 specific=0 (which we map to Mac) is not supported by your version of iconv(3).
Nerd Fonts Patcher v2.3.0-RC (3.2.0) executing

Nerd Fonts: Processing Atkinson Hyperlegible Bold (1/1)
No configfile given, skipping configfile related actions
Adding 177 Glyphs from Seti-UI + Custom Set
╢████████████████████████████████████████╟ 100%
Adding 198 Glyphs from Devicons Set
╢████████████████████████████████████████╟ 100%

Done with Patch Sets, generating font...

Nerd Fonts: Tweaking 1/1
Changing lowestRecPPEM from 8 to 6

Generated: Atkinson Hyperlegible Bold Nerd Font in '/out/Atkinson Hyperlegible Bold Nerd Font.ttf'
Internal Error: Your version of iconv does not support the "Mac Roman" encoding.
If this causes problems, reconfigure --without-iconv.
Copyright (c) 2000-2022. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20220308
 Based on sources from 2022-07-24 20:58 UTC-D.
 Based on source from git with hash: 3714b0323943afc54607f9404b672ca469364cb3
The truetype encoding specified by platform=1 specific=0 (which we map to Mac) is not supported by your version of iconv(3).
Nerd Fonts Patcher v2.3.0-RC (3.2.0) executing

Nerd Fonts: Processing Atkinson Hyperlegible Bold Italic (1/1)
No configfile given, skipping configfile related actions
Adding 177 Glyphs from Seti-UI + Custom Set
╢████████████████████████████████████████╟ 100%
Adding 198 Glyphs from Devicons Set
╢████████████████████████████████████████╟ 100%

Done with Patch Sets, generating font...

Nerd Fonts: Tweaking 1/1
Changing lowestRecPPEM from 8 to 6

Generated: Atkinson Hyperlegible Bold Italic Nerd Font in '/out/Atkinson Hyperlegible Bold Italic Nerd Font.ttf'
Internal Error: Your version of iconv does not support the "Mac Roman" encoding.
If this causes problems, reconfigure --without-iconv.
Copyright (c) 2000-2022. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20220308
 Based on sources from 2022-07-24 20:58 UTC-D.
 Based on source from git with hash: 3714b0323943afc54607f9404b672ca469364cb3
The truetype encoding specified by platform=1 specific=0 (which we map to Mac) is not supported by your version of iconv(3).
Nerd Fonts Patcher v2.3.0-RC (3.2.0) executing

Nerd Fonts: Processing Atkinson Hyperlegible Italic (1/1)
No configfile given, skipping configfile related actions
Adding 177 Glyphs from Seti-UI + Custom Set
╢████████████████████████████████████████╟ 100%
Adding 198 Glyphs from Devicons Set
╢████████████████████████████████████████╟ 100%

Done with Patch Sets, generating font...

Nerd Fonts: Tweaking 1/1
Changing lowestRecPPEM from 8 to 6

Generated: Atkinson Hyperlegible Italic Nerd Font in '/out/Atkinson Hyperlegible Italic Nerd Font.ttf'
Internal Error: Your version of iconv does not support the "Mac Roman" encoding.
If this causes problems, reconfigure --without-iconv.
Copyright (c) 2000-2022. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20220308
 Based on sources from 2022-07-24 20:58 UTC-D.
 Based on source from git with hash: 3714b0323943afc54607f9404b672ca469364cb3
The truetype encoding specified by platform=1 specific=0 (which we map to Mac) is not supported by your version of iconv(3).
Nerd Fonts Patcher v2.3.0-RC (3.2.0) executing

Nerd Fonts: Processing Atkinson Hyperlegible Regular (1/1)
No configfile given, skipping configfile related actions
Adding 177 Glyphs from Seti-UI + Custom Set
╢████████████████████████████████████████╟ 100%
Adding 198 Glyphs from Devicons Set
╢████████████████████████████████████████╟ 100%

Done with Patch Sets, generating font...

Nerd Fonts: Tweaking 1/1
Changing lowestRecPPEM from 8 to 6

Generated: Atkinson Hyperlegible Regular Nerd Font in '/out/Atkinson Hyperlegible Regular Nerd Font.ttf'

Finii · 2022-10-29T08:31:39Z

Internal Error: Your version of iconv does not support the "Mac Roman" encoding.

Ah, we base the docker on Alpine iirc, and they use musl's iconv instead of glibc's. And that indeed has no Mac encoding:

The relevant code is here: https://github.com/fontforge/fontforge/blob/-/fontforge/encoding.c#L196

CI: Use standard Docker build Actions, enable builds for ARM architecture

feat: use standard Docker build Actions

3f755e4

This was referenced Oct 27, 2022

Fix Failing Docker Builds #882

Merged

Unable to patch fonts on Apple silicon #662

Closed

Finii approved these changes Oct 28, 2022

View reviewed changes

CI: Small changes on docker workflow

3cc1d20

[why] Credentials not needed (I guess). Workflow is never run on pull-requests, so no check needed. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii merged commit 229a154 into ryanoasis:master Oct 28, 2022

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023

Merge pull request ryanoasis#985 from sammcj/master

6563ddc

CI: Use standard Docker build Actions, enable builds for ARM architecture

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use standard Docker build Actions, enable builds for ARM architecture #985

feat: use standard Docker build Actions, enable builds for ARM architecture #985

sammcj commented Oct 27, 2022

Finii left a comment

Finii Oct 28, 2022

Finii Oct 28, 2022

Finii commented Oct 28, 2022

Finii commented Oct 28, 2022

sammcj commented Oct 28, 2022

Finii commented Oct 28, 2022

sammcj commented Oct 29, 2022

sammcj commented Oct 29, 2022

Finii commented Oct 29, 2022 •

edited

Loading

feat: use standard Docker build Actions, enable builds for ARM architecture #985

feat: use standard Docker build Actions, enable builds for ARM architecture #985

Conversation

sammcj commented Oct 27, 2022

Description

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii left a comment

Choose a reason for hiding this comment

Finii Oct 28, 2022

Choose a reason for hiding this comment

Finii Oct 28, 2022

Choose a reason for hiding this comment

Finii commented Oct 28, 2022

Finii commented Oct 28, 2022

sammcj commented Oct 28, 2022

Finii commented Oct 28, 2022

sammcj commented Oct 29, 2022

sammcj commented Oct 29, 2022

Finii commented Oct 29, 2022 • edited Loading

Finii commented Oct 29, 2022 •

edited

Loading