Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.0 => 0.12.1 version upgrade is a bit painful #204

Closed
nfedyashev opened this issue Aug 22, 2019 · 3 comments
Closed

0.12.0 => 0.12.1 version upgrade is a bit painful #204

nfedyashev opened this issue Aug 22, 2019 · 3 comments

Comments

@nfedyashev
Copy link

Still love your gem, just a minor comment on 0.12.0 => 0.12.1 version upgrade pain points.

Before upgrading from 0.12.0 to 0.12.1 I checked the changelog at https://github.com/ryanto/acts_as_votable/releases

and corresponding pull requests

#202 #198 Rails 6 (@BillyParadise @murny)
#201 #200 Gem cleanup (@olleolleolle)

Failure message wasn't very helpful without checking the source code

Failure/Error: acts_as_votable cacheable_strategy: :update_attributes

ArgumentError:
  update_attributes
# ./app/models/entry.rb:48:in `<class:Entry>'

that's how I found this important commit that somehow wasn't mentioned in the changelog
80d8296

It doesn't feel like a patch-level version upgrade because it is not backward compatible.

@ryanto
Copy link
Owner

ryanto commented Aug 27, 2019

I'm sorry about that!

I'll release a new version that has the breaking change and how to upgrade.

What did you end up doing to fix it?

@nfedyashev
Copy link
Author

@ryanto
the fix was to change rename cacheable strategy

< cacheable_strategy: update_attributes
> cacheable_strategy: :update

@ryanto
Copy link
Owner

ryanto commented Dec 19, 2020

Ok thank you for that. I finally got this one documented in the releases :)

@ryanto ryanto closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants