Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cast entity_category string to EntityCategory enum #3

Merged
merged 1 commit into from
Aug 17, 2022
Merged

cast entity_category string to EntityCategory enum #3

merged 1 commit into from
Aug 17, 2022

Conversation

Kirmas
Copy link

@Kirmas Kirmas commented Aug 17, 2022

  • fix for using entity_category in the decorator

@Kirmas Kirmas requested a review from rytilahti as a code owner August 17, 2022 20:10
@Kirmas Kirmas mentioned this pull request Aug 17, 2022
Merged
rytilahti
rytilahti approved these changes Aug 17, 2022
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 I never tested this, nor are there any tests yet, but let's just merge it for now :-)

@rytilahti rytilahti merged commit 7cec2a3 into rytilahti:xiaomi_miio/feat/entities_from_upstream Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kirmas @rytilahti