From 60a34688b336969f72fd66ce15818d4f07c98a8b Mon Sep 17 00:00:00 2001 From: Thibault Cohen Date: Sun, 20 Dec 2020 22:56:35 -0500 Subject: [PATCH] Add tests --- miio/device.py | 2 +- miio/tests/test_device.py | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/miio/device.py b/miio/device.py index af8672a04..00753c647 100644 --- a/miio/device.py +++ b/miio/device.py @@ -147,7 +147,7 @@ def send( :param int retry_count: How many times to retry on error :param dict extra_parameters: Extra top-level parameters """ - retry_count = retry_count if retry_count is not None else self._retry_count + retry_count = retry_count if retry_count is not None else self.retry_count return self._protocol.send( command, parameters, retry_count, extra_parameters=extra_parameters ) diff --git a/miio/tests/test_device.py b/miio/tests/test_device.py index 1aeede968..e60cf428c 100644 --- a/miio/tests/test_device.py +++ b/miio/tests/test_device.py @@ -17,6 +17,17 @@ def test_get_properties_splitting(mocker, max_properties): if max_properties is None: max_properties = len(properties) assert send.call_count == math.ceil(len(properties) / max_properties) + assert 5 == d._protocol._timeout + + +def test_timeout_retry(mocker): + send = mocker.patch("miio.miioprotocol.MiIOProtocol.send") + d = Device("127.0.0.1", "68ffffffffffffffffffffffffffffff", timeout=4) + assert 4 == d._protocol._timeout + d.send("fake_command", [], 1) + send.assert_called_with("fake_command", [], 1, extra_parameters=None) + d.send("fake_command", []) + send.assert_called_with("fake_command", [], 3, extra_parameters=None) def test_unavailable_device_info_raises(mocker):