Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement is pinned for python-miio 0.5.6: defusedxml>=0.6,<0.7 #1062

Closed
MartinHjelmare opened this issue Jun 1, 2021 · 1 comment · Fixed by #1073
Closed

Requirement is pinned for python-miio 0.5.6: defusedxml>=0.6,<0.7 #1062

MartinHjelmare opened this issue Jun 1, 2021 · 1 comment · Fixed by #1073
Labels

Comments

@MartinHjelmare
Copy link

Describe the bug

Thanks for your support of Home Assistant!

Version information (please complete the following information):

  • OS: Linux
  • python-miio: 0.5.6

Device information:

To Reproduce
Steps to reproduce the behavior:

(home-assistant) x:~/dev/home-assistant/core$ pip install -r requirements_all.txt
(home-assistant) x:~/dev/home-assistant/core$ pipdeptree -w silence -r -p defusedxml | grep python-miio
 - python-miio==0.5.6 [requires: defusedxml>=0.6,<0.7]

Expected behavior

  • To avoid future issues it would be good if this library would change its pinning to allow any higher version and just set a minimum version. Or set a maximum version that is more forgiving.

Console output

@rytilahti
Copy link
Owner

Good catch! Requiring defusedxml is rather recent addition and I didn't pay enough attention to simply pin on the major version. The linked PR changes allows now all 0.x series to fulfill that requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants