Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pretty-cron dependency with cron_descriptor #423

Closed
pluehne opened this issue Nov 27, 2018 · 6 comments · Fixed by #548
Closed

Replace pretty-cron dependency with cron_descriptor #423

pluehne opened this issue Nov 27, 2018 · 6 comments · Fixed by #548

Comments

@pluehne
Copy link
Contributor

pluehne commented Nov 27, 2018

I just realized that pretty_cron is used in a few places in this project but the authors of pretty_cron state that it is no longer maintained:

Retired in favour of cron_descriptor.

This project is no longer maintained.

It might make sense to follow the original authors’ recommendation to switch to cron_descriptor instead. Consider this just as a heads-up 🙂.

@rytilahti
Copy link
Owner

Thanks for reporting this Patrick! pretty_cron is used only in one place (converting cron format to printable format) in mirobo cli tool, however, I don't think the timer functionality is used that much here. The conversion seems to be straightforward though, so I suppose we can either make the change or simply drop the dependency altogether.

@pluehne
Copy link
Contributor Author

pluehne commented Nov 27, 2018

@rytilahti: That sounds good! I may be able to help with replacing or dropping the dependency, but I’ll be pretty busy until the end of the year.

@rytilahti
Copy link
Owner

Ok, this is definitely a low priority, and I think changing the dependency should be combined with making the timer functionality more straightforward to use (currently you need to construct your cron string, make sure everything is fine related to the active timezone etc. to use it). But if you want to tackle this, please feel free to do so :-)

@pluehne
Copy link
Contributor Author

pluehne commented Nov 27, 2018

I’ll see what I can do. But if you have concrete plans to improve the timer interface, feel free to go ahead and don’t wait for me 🙂!

@rytilahti
Copy link
Owner

As I'm not personally using it at all (preferring to handle scheduling via other means), so it's not of importance to me, and as is, it's just there for completeness. Therefore I'm wondering if the dependency should be dropped altogether, but I have really no plans on this for a way or another.

rytilahti added a commit that referenced this issue Feb 5, 2019
rytilahti added a commit that referenced this issue Feb 9, 2019
@frostworx
Copy link

looks like this is already fixed. the only occurence of "pretty_cron" is in requirements.txt

rytilahti added a commit that referenced this issue Sep 10, 2019
The former is not used anymore, and the latter is irrelevant as we depend already on python 3.5+. Closes #423.
rytilahti added a commit that referenced this issue Sep 10, 2019
The former is not used anymore, and the latter is irrelevant as we depend already on python 3.5+. Closes #423.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants