-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-miio v0.5.0 incomplete utils.py #659
Comments
@rytilahti do you have any idea what is going on? |
Uhhh, that's really odd.. Must be caused by basing the preparations branch & tagging over wrong tip... I'll prepare 0.5.0.1 to fix that asap. |
Some changes were left out from the previous release, this simply adds them back. Fixes #659
Some changes were left out from the previous release, this simply adds them back. Fixes #659
@rytilahti thanks for fixing this so quickly! |
Thank you for quick testing & reporting :-) Goes much faster this way, than realizing it after it's been propagated to downstream. I think this shows the release process needs some improvements though, to avoid having this again in the future... |
When I look at the master branch of rytilahti/python-miio in the file:
python-miio/miio/utils.py
the functionint_to_brightness
is there.However when I download the source_code of the v0.5.0 release from: https://github.com/rytilahti/python-miio/archive/0.5.0.zip
And extract the files and then look into
python-miio/miio/utils.py
the functionint_to_brightness
is not there.This causes an import error when installing python-miio through
pip3 install --upgrade python-miio
and then trying to import the gateway class:The text was updated successfully, but these errors were encountered: