Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Xiaomi Air purifier 3C #888

Closed
arturdobo opened this issue Dec 11, 2020 · 4 comments
Closed

Support for Xiaomi Air purifier 3C #888

arturdobo opened this issue Dec 11, 2020 · 4 comments

Comments

@arturdobo
Copy link
Contributor

Device information:

  • Name(s) of the device: Xiaomi Air purifier 3C

Use miiocli device --ip <ip address> --token <token>.

  • Model: zhimi.airpurifier.mb4
  • Hardware version: esp32
  • Firmware version: 2.0.8

Additional context

After a quick investigation, it looks like the specification for Xiaomi Air purifier 3C is a little bit different than the one used currently for air purifiers and only a few of properties match. As a result, it causes -4005 code on the majority of fields.

I could prepare some PR to solve that issue, but I'm new in this area and I'd like to confirm whether the way the similar issue has been resolved here is a good way to follow?

@arturdobo
Copy link
Contributor Author

Air Purifier 3C supports only a subset of current features declared in AirPurifierMiot. The model needs to be split into two separated ones I believe but I'd like to consult whether my proposal I started work on https://github.com/arturdobo/python-miio/commit/6c911e37d1005f9235fa5d3c6856655d40e4263d is something acceptable or not. If not, could you give me some idea of how to do this? And more thing, I'm not a Python developer, so I don't if my code is idiomatic or not 😛

@arturdobo
Copy link
Contributor Author

Because of no feedback for 3 weeks, I created #899 for that change

@calas80
Copy link

calas80 commented Feb 17, 2021

Hi,

I have this device, I am very much waiting for an update.

Thanks for this pluging.

@rytilahti
Copy link
Owner

This has been implemented in #899, thanks to @arturdobo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants