Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roborock S6 MaxV] Need a delay between pause and charge commands to return to dock #918

Closed
stephalltricks opened this issue Jan 24, 2021 · 6 comments · Fixed by #933 or #1050
Closed

Comments

@stephalltricks
Copy link

stephalltricks commented Jan 24, 2021

https://github.com/rytilahti/python-miio/blob/5730f535d4691e0c2b4260cd7835b7a43ddc8ab0/miio/vacuum.py#L145:L148

When my Roborock S6 is running, if I run the "home" function, it only makes it pause. I need to run the "home" function a second time to make it go to base.

It needs a delay bewteen the "app_pause" and the "app_charge" commands.

@stephalltricks stephalltricks changed the title [Roborock S6 MaxV] Need a delay between pause and dock commands [Roborock S6 MaxV] Need a delay between pause and charge commands to return to dock Jan 24, 2021
@rytilahti
Copy link
Owner

Could you try modifying your local instance to skip the app_pause completely to see if that works on that device? Adding a very short pause would be fine, I suppose, but how long should that be?

@stephalltricks
Copy link
Author

Hello @rytilahti
You're right, if I remove app_pause completely it works!

@rytilahti
Copy link
Owner

Okay, great! I think we can do a similar handling as with fan_speed_presets and change the behavior of that command depending on the detected device model.

I'd still like to hear some results from people using other devices (besides gen1 vacuums), maybe it's only gen1 that requires pausing prior to asking it to return.

@stephanerosi
Copy link

stephanerosi commented Jan 26, 2021

For your information, I've run a few more tests :

If I add an app_stop (instead of app_pause) : same problem
if I add a delay of 1sec between app_pause and app_charge : it works
If I remove app_pause : it works

55356b474c4b793941526b62306233 info
Model: roborock.vacuum.a10
Hardware version: Linux
Firmware version: 3.5.8_519

@rytilahti
Copy link
Owner

Thanks for your tests @stephanerosi, the linked PR adds a special handling for roborock.vacuum.a10, feel free to test it out before it gets merged :-)

@stephanerosi
Copy link

Just checked out locally and tested.
Works perfectly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants