-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features for newer vacuums (eg Roborock S7) #1039
Add features for newer vacuums (eg Roborock S7) #1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of more comments, but otherwise this looks good to go. I'm unsure if the best action for unsupported actions is to raise an exception or simply to log it, but let's go for logging for now to make it simpler for downstreams.
The vacuum class (when the API gets consolidated) should get a supported_features()
property at some point to allow introspecting which commands and features are available for the given model. Until then, I think it's better to (non-silently) signal for invalid usage instead of raising an exception.
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it, thanks again for the PR and your patience! 🥇
I added the following features to the vacuums. Support for them may vary depending on the model of the vacuum. All of these at least work for the Roborock S7
Closes #1040