Add the ability to define a timezone for configure_wifi #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 29, 2017
setup.py
Outdated
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| packages=["miio", "mirobo"], | |||
|
|
|||
| install_requires=['construct', 'click', 'cryptography', 'pretty_cron', 'typing', 'zeroconf', 'pycrypto', 'attrs'], | |||
| install_requires=['construct', 'click', 'cryptography', 'pretty_cron', 'typing', 'zeroconf', 'pycrypto', 'attrs', 'pytz'], | |||
There was a problem hiding this comment.
line too long (126 > 79 characters)
This will allow passing the timezone to vacuums running newer firmware versions, as mentioned in PR #105
rytilahti
force-pushed
the
add_timezone_config
branch
from
b5a2e4b to
b99633e
Compare
|
Good work! Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow passing the timezone to vacuums running
newer firmware versions, as mentioned in PR #105
Thanks to @marcelrv for pointing this out.