-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add water_level
and water_tank_detached
property for humidifiers, deprecate depth
#1089
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1089 +/- ##
==========================================
+ Coverage 75.43% 75.45% +0.02%
==========================================
Files 74 74
Lines 8372 8386 +14
Branches 743 745 +2
==========================================
+ Hits 6315 6328 +13
- Misses 1875 1876 +1
Partials 182 182 ☔ View full report in Codecov by Sentry. |
water_level
property for humidifierswater_level
and water_tank_detached
property for humidifiers, deprecate depth
@rytilahti Are you planning to release a new version? The migration of humidifiers from the |
Yes, I'll prepare a new release when I return from the holidays (i.e., there should be a new release available in a couple of weeks), if @syssi doesn't beat me with that. Sorry for the delay :/ |
No problem, enjoy the holidays. |
This PR:
water_level
property for AirHumidifier (value is calculated fromdepth
)water_tank_detached
for AirHumidifier (value is calculated fromdepth
)water_level
calculation for AirHumidifierMiotwater_tank_detached
for AirHumidifierMiot (value is calculated fromwater_level
)