Update chuangmi_ir.py to accept 2 arguments (frequency and length) #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the arg_types variable to have a length of 2 in order to be able to use something like this (both frequency and length): miiocli chuangmiir --ip 192.168.10.14 --token REDACTED play "raw:mc0mU0lkxm00mEsmkznEsmMzmM0AIqazYAPwA1Ag8BjwIfAy8DLwMvAZ8BnwIfAY8BjwA/AD8APwA/AD8APwA/AD8APwqPCo8PzwIfAD8APwSfFX8FHwA/AD8APwA/AD8APwA/AD8APwA/AD8APwA/AD8APwA/AD8APwA/AD8APxgfFw8APwKPAY+bA=:38000:224"
|
What's the model as reported by info? Could it be the the previous version uses the single argument format? |
|
Model: chuangmi.remote.v2 |
|
Thank @mpsOxygen for finding the issue. This bug was introduced from my previous pull request in #1043 which added length parameter for chuangmi.remote.v2 . |
Dozku
approved these changes
Jul 17, 2021
|
Ah, I see. Okay, I trust you on this and will merge it for the next release. Thanks for the PR @mpsOxygen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the arg_types variable to have a length of 2 in order to be able to use something like this (both frequency and length):
miiocli chuangmiir --ip 192.168.10.14 --token REDACTED play "raw:mc0mU0lkxm00mEsmkznEsmMzmM0AIqazYAPwA1Ag8BjwIfAy8DLwMvAZ8BnwIfAY8BjwA/AD8APwA/AD8APwA/AD8APwqPCo8PzwIfAD8APwSfFX8FHwA/AD8APwA/AD8APwA/AD8APwA/AD8APwA/AD8APwA/AD8APwA/AD8APxgfFw8APwKPAY+bA=:38000:224"