Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark device_classes inside devicegroupmeta as private #1129

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

rytilahti
Copy link
Owner

This container shouldn't have been exposed directly to the inheriting classes.
The cli will now use the newly introduced property to access the type objects.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1129 (fa2d1cb) into master (26795b5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files          75       75           
  Lines        8852     8852           
  Branches      762      762           
=======================================
  Hits         6738     6738           
  Misses       1930     1930           
  Partials      184      184           
Impacted Files Coverage Δ
miio/click_common.py 44.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26795b5...fa2d1cb. Read the comment docs.

@rytilahti rytilahti merged commit fc47803 into master Sep 2, 2021
@rytilahti rytilahti deleted the refactor/privatize_device_classes branch September 2, 2021 04:31
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants