Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TypeError in gateway property exception handling #1138

Merged
merged 1 commit into from
Sep 16, 2021
Merged

fix TypeError in gateway property exception handling #1138

merged 1 commit into from
Sep 16, 2021

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG mentioned this pull request Sep 13, 2021
Closed
22 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021 •
edited
Loading

Codecov Report

Merging #1138 (2a46a3e) into master (9ad62be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1138   +/-   ##
=======================================
  Coverage   74.81%   74.81%           
=======================================
  Files          76       76           
  Lines        9006     9006           
  Branches      769      769           
=======================================
  Hits         6738     6738           
  Misses       2084     2084           
  Partials      184      184
Impacted Files Coverage Δ
miio/gateway/devices/subdevice.py 36.87% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad62be...2a46a3e. Read the comment docs.

@starkillerOG
Copy link
Contributor Author

@rytilahti could you merge this?

@rytilahti rytilahti changed the title fix TypeError in formatting fix TypeError in gateway property exception handling Sep 16, 2021
@rytilahti rytilahti merged commit 4371537 into rytilahti:master Sep 16, 2021
@rytilahti rytilahti added the bug label Nov 30, 2021
@rytilahti rytilahti mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@starkillerOG @codecov-commenter @rytilahti