Remove unnecessary subclass constructors, deprecate subclasses only setting the model #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting the model * Remove constructors that just called the super class constructor with the model information * Deprecate subclasses that were previously there to allow miiocli usage when no model parameter passing was possible
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
==========================================
- Coverage 76.08% 76.06% -0.02%
==========================================
Files 76 76
Lines 8961 8921 -40
Branches 747 748 +1
==========================================
- Hits 6818 6786 -32
+ Misses 1957 1951 -6
+ Partials 186 184 -2
Continue to review full report at Codecov.
|
This was referenced Nov 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify refactoring the constructor parameters in the future, this PR will remove the unnecessary constructors.
This PR also deprecates subclasses that were merely used to expose the parent device using a given model to miiocli, which is no longer necessary thanks to #1038.
The device class requires better handling for model specific properties (esp. for miotdevice which currently uses
self.mappingwhich makes it harder to get rid of those extra classes), but that's a task for another PR.