Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emptying bin status for roborock s7+ #1190

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

rytilahti
Copy link
Owner

Fixes #1189

@rytilahti rytilahti force-pushed the vacuum/fix/roborock_s7_returning_home branch from df96a92 to b69ba83 Compare November 29, 2021 00:43
@rytilahti
Copy link
Owner Author

rytilahti commented Nov 29, 2021

As noted in the linked issue, this might be "emptying the bin" instead of "returning home" so this is pending for input for now..

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #1190 (2c9df3b) into master (9ba55a9) will increase coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   78.39%   79.25%   +0.85%     
==========================================
  Files          88       90       +2     
  Lines        9656     9722      +66     
  Branches     1129     1130       +1     
==========================================
+ Hits         7570     7705     +135     
+ Misses       1897     1825      -72     
- Partials      189      192       +3     
Impacted Files Coverage Δ
...o/integrations/vacuum/roborock/vacuumcontainers.py 76.70% <ø> (ø)
miio/discovery.py 49.33% <0.00%> (ø)
miio/waterpurifier.py 100.00% <0.00%> (ø)
miio/vacuum.py 100.00% <0.00%> (ø)
.../integrations/vacuum/roborock/tests/test_mirobo.py 100.00% <0.00%> (ø)
miio/philips_moonlight.py 99.00% <0.00%> (+<0.01%) ⬆️
miio/philips_eyecare.py 99.00% <0.00%> (+0.01%) ⬆️
miio/airconditioningcompanion.py 97.48% <0.00%> (+0.01%) ⬆️
miio/ceil.py 98.87% <0.00%> (+0.01%) ⬆️
miio/airfresh_t2017.py 96.17% <0.00%> (+0.02%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba55a9...2c9df3b. Read the comment docs.

@rytilahti rytilahti changed the title Add returning home status for roborock s7+ Add emptying bin status for roborock s7+ Dec 5, 2021
@rytilahti rytilahti merged commit 48717d9 into master Dec 5, 2021
@rytilahti rytilahti deleted the vacuum/fix/roborock_s7_returning_home branch December 5, 2021 16:32
rytilahti added a commit that referenced this pull request Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models:
* philips_bulb now defaults to a bulb that has color temperature setting
* gateway devices do not perform an info query as that is handled by their parent

Also, the list of the supported models was extended thanks to the feedback from the community!

[Full Changelog](0.5.9.1...0.5.9.2)

**Implemented enhancements:**

- Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost))
- Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti))
- Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti))

**Fixed bugs:**

- Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86))
- gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG))
- mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti))
- Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n))

**Merged pull requests:**

- philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas))
- Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas))
- Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti))
- Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh))
- vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti))
- philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
@rytilahti rytilahti mentioned this pull request Dec 14, 2021
rytilahti added a commit that referenced this pull request Dec 14, 2021
This release fixes regressions caused by the recent refactoring related to supported models:
* philips_bulb now defaults to a bulb that has color temperature setting
* gateway devices do not perform an info query as that is handled by their parent

Also, the list of the supported models was extended thanks to the feedback from the community!

[Full Changelog](0.5.9.1...0.5.9.2)

**Implemented enhancements:**

- Add yeelink.bhf\_light.v2 and yeelink.light.lamp22 support [\#1250](#1250) ([FaintGhost](https://github.com/FaintGhost))
- Skip warning if the unknown model is reported on a base class [\#1243](#1243) ([rytilahti](https://github.com/rytilahti))
- Add emptying bin status for roborock s7+ [\#1190](#1190) ([rytilahti](https://github.com/rytilahti))

**Fixed bugs:**

- Fix Roborock S7 fan speed [\#1235](#1235) ([shred86](https://github.com/shred86))
- gateway: remove click support for gateway devices [\#1229](#1229) ([starkillerOG](https://github.com/starkillerOG))
- mirobo: make sure config always exists [\#1207](#1207) ([rytilahti](https://github.com/rytilahti))
- Fix typo [\#1204](#1204) ([com30n](https://github.com/com30n))

**Merged pull requests:**

- philips\_eyecare: add philips.light.sread1 as supported [\#1246](#1246) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color3 support [\#1245](#1245) ([Kirmas](https://github.com/Kirmas))
- Use codecov-action@v2 for CI [\#1244](#1244) ([rytilahti](https://github.com/rytilahti))
- Add yeelink.light.color5 support [\#1242](#1242) ([Kirmas](https://github.com/Kirmas))
- Add more supported devices to their corresponding classes [\#1237](#1237) ([rytilahti](https://github.com/rytilahti))
- Add zhimi.humidfier.ca4 as supported model [\#1220](#1220) ([jbouwh](https://github.com/jbouwh))
- vacuum: Add t7s \(roborock.vacuum.a14\) [\#1214](#1214) ([rytilahti](https://github.com/rytilahti))
- philips\_bulb: add philips.light.downlight to supported devices [\#1212](#1212) ([rytilahti](https://github.com/rytilahti))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roborock: add S7+ status code 22
2 participants