Add common API for constructing device instances, improve introspection #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New class methods in Device: * all_supported_models() to return a dictionary model=>implementation class * class_for_model(model: str) to return implementation class for the given model * create(host: str, token: str, model: Optional[str]) to create a device instance New cli commands: * `miiocli supported-models` will print a list of supported models
* Add wildcard support (required for yeelight to avoid I/O for supported models) * Do not overwrite existing implementations (required for gateway/airconditioningcompanion clash) * Fix supported devices for airfresh, airconditioningcompanion subclasses
rytilahti
force-pushed
the
feat/device_for_model
branch
from
f7e575a to
f069a0b
Compare
This was referenced Mar 19, 2022
This was referenced Aug 13, 2022
|
Superseded by #1556 |
rytilahti
added a commit
that referenced
this pull request
Oct 23, 2022
This will make it simple for downstream users to construct device instances for all supported devices given only the host and its token. All device subclasses register themselves automatically to the factory. The create(host, token, model=None) class method is the main entry point to use this. Supersedes #1328 Fixes #1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New class methods in Device:
New cli commands:
miiocli supported-modelswill print a list of supported modelsTBD:
Fixes #1117