From cfd3edac2525d558d87dac47cb96f50520b8e68c Mon Sep 17 00:00:00 2001
From: Sebastian Muszynski <s.muszynski@constructiva.de>
Date: Mon, 27 Nov 2017 08:24:24 +0100
Subject: [PATCH] Unit tests for the Xiaomi Air Humidifier added.

---
 miio/airhumidifier.py            |   2 +-
 miio/tests/test_airhumidifier.py | 127 +++++++++++++++++++++++++++++++
 2 files changed, 128 insertions(+), 1 deletion(-)
 create mode 100644 miio/tests/test_airhumidifier.py

diff --git a/miio/airhumidifier.py b/miio/airhumidifier.py
index 563666244..d72888ea8 100644
--- a/miio/airhumidifier.py
+++ b/miio/airhumidifier.py
@@ -84,7 +84,7 @@ def status(self) -> AirHumidifierStatus:
         """Retrieve properties."""
 
         properties = ['power', 'mode', 'temp_dec', 'humidity', 'buzzer',
-                      'led_b', ]
+                      'led_b', 'led', ]
 
         values = self.send(
             "get_prop",
diff --git a/miio/tests/test_airhumidifier.py b/miio/tests/test_airhumidifier.py
new file mode 100644
index 000000000..6fb3e6b48
--- /dev/null
+++ b/miio/tests/test_airhumidifier.py
@@ -0,0 +1,127 @@
+from unittest import TestCase
+from miio import AirHumidifier
+from miio.airhumidifier import OperationMode, LedBrightness
+from .dummies import DummyDevice
+import pytest
+
+
+class DummyAirHumidifier(DummyDevice, AirHumidifier):
+    def __init__(self, *args, **kwargs):
+        self.state = {
+            'power': 'on',
+            'mode': 'medium',
+            'temp_dec': 186,
+            'humidity': 62,
+            'buzzer': 'off',
+            'led': 'off',
+            'led_b': 2,
+        }
+        self.return_values = {
+            'get_prop': self._get_state,
+            'set_power': lambda x: self._set_state("power", x),
+            'set_mode': lambda x: self._set_state("mode", x),
+            'set_led': lambda x: self._set_state("led", x),
+            'set_led_b': lambda x: self._set_state("led_b", x),
+            'set_buzzer': lambda x: self._set_state("buzzer", x),
+        }
+        super().__init__(args, kwargs)
+
+
+@pytest.fixture(scope="class")
+def airhumidifier(request):
+    request.cls.device = DummyAirHumidifier()
+    # TODO add ability to test on a real device
+
+
+@pytest.mark.usefixtures("airhumidifier")
+class TestAirHumidifier(TestCase):
+    def is_on(self):
+        return self.device.status().is_on
+
+    def state(self):
+        return self.device.status()
+
+    def test_on(self):
+        self.device.off()  # ensure off
+
+        start_state = self.is_on()
+        assert start_state is False
+
+        self.device.on()
+        assert self.is_on() is True
+
+    def test_off(self):
+        self.device.on()  # ensure on
+
+        assert self.is_on() is True
+        self.device.off()
+        assert self.is_on() is False
+
+    def test_status(self):
+        self.device._reset_state()
+
+        assert self.is_on() is True
+        assert self.state().temperature == self.device.start_state["temp_dec"] / 10.0
+        assert self.state().humidity == self.device.start_state["humidity"]
+        assert self.state().mode == OperationMode(self.device.start_state["mode"])
+        assert self.state().led == (self.device.start_state["led"] == 'on')
+        assert self.state().led_brightness == LedBrightness(self.device.start_state["led_b"])
+        assert self.state().buzzer == (self.device.start_state["buzzer"] == 'on')
+
+    def test_set_mode(self):
+        def mode():
+            return self.device.status().mode
+
+        self.device.set_mode(OperationMode.Silent)
+        assert mode() == OperationMode.Silent
+
+        self.device.set_mode(OperationMode.Medium)
+        assert mode() == OperationMode.Medium
+
+        self.device.set_mode(OperationMode.High)
+        assert mode() == OperationMode.High
+
+    def test_set_led_brightness(self):
+        def led_brightness():
+            return self.device.status().led_brightness
+
+        self.device.set_led_brightness(LedBrightness.Bright)
+        assert led_brightness() == LedBrightness.Bright
+
+        self.device.set_led_brightness(LedBrightness.Dim)
+        assert led_brightness() == LedBrightness.Dim
+
+        self.device.set_led_brightness(LedBrightness.Off)
+        assert led_brightness() == LedBrightness.Off
+
+    def test_set_led(self):
+        def led():
+            return self.device.status().led
+
+        self.device.set_led(True)
+        assert led() is True
+
+        self.device.set_led(False)
+        assert led() is False
+
+    def test_set_buzzer(self):
+        def buzzer():
+            return self.device.status().buzzer
+
+        self.device.set_buzzer(True)
+        assert buzzer() is True
+
+        self.device.set_buzzer(False)
+        assert buzzer() is False
+
+    def test_status_without_temperature(self):
+        self.device._reset_state()
+        self.device.state["temp_dec"] = None
+
+        assert self.state().temperature is None
+
+    def test_status_without_led_brightness(self):
+        self.device._reset_state()
+        self.device.state["led_b"] = None
+
+        assert self.state().led_brightness is None