Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure miotdevice implementations define supported models #1345

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

rytilahti
Copy link
Owner

Previously only implementations directly inheriting from Device were tested to ensure the existence of _supported_models.
This PR extends the tests to check it for MiotDevice inheriting classes, and adds model information for:

  • CurtainMiot
  • Huizuo
  • FanMiot, Fan1C
  • FanZA5
  • RoidmiVacuumMiot
  • YeelightDualControlModule

Fixes #1344

Add model information to:
* CurtainMiot
* Huizuo
* FanMiot, Fan1C
* FanZA5
* RoidmiVacuumMiot
* YeelightDualControlModule
@rytilahti rytilahti force-pushed the zhimi_miot/add_fanza5 branch from e93ba59 to 566e401 Compare March 4, 2022 14:37
@rytilahti rytilahti merged commit 2286e58 into master Mar 4, 2022
@rytilahti rytilahti deleted the zhimi_miot/add_fanza5 branch March 4, 2022 14:54
rytilahti added a commit that referenced this pull request Mar 7, 2022
This release fixes zhimi.fan.za5 support and makes all integrations introspectable for their supported models.
For developers, there is now a network trace parser (in devtools/parse_pcap.py) that prints the decrypted the traffic for given tokens.

The following previously deprecated classes in favor of model-based discovery, if you were using these classes directly you need to adjust your code:
* AirFreshVA4 - use AirFresh
* AirHumidifierCA1, AirHumidifierCB1, AirHumidifierCB2 - use AirHumidifier
* AirDogX5, AirDogX7SM - use AirDogX3
* AirPurifierMB4 - use AirPurifierMiot
* Plug, PlugV1, PlugV3 - use ChuangmiPlug
* FanP9, FanP10, FanP11 - use FanMiot
* DreameVacuumMiot - use DreameVacuum
* Vacuum - use RoborockVacuum

[Full Changelog](0.5.10...0.5.11)

**Breaking changes:**

- Remove deprecated integration classes [\#1343](#1343) (@rytilahti)

**Implemented enhancements:**

- Add PCAP file parser for protocol analysis [\#1331](#1331) (@rytilahti)

**Fixed bugs:**

- Fix bug for zhimi.fan.za5 resulting in user ack timeout [\#1348](#1348) (@saxel)

**Deprecated:**

- Deprecate wifi\_led in favor of led [\#1342](#1342) (@rytilahti)

**Merged pull requests:**

- Make sure miotdevice implementations define supported models [\#1345](#1345) (@rytilahti)
- Add Viomi V2 \(viomi.vacuum.v6\) as supported [\#1340](#1340) (@rytilahti)
- Mark Roborock S7 MaxV \(roborock.vacuum.a27\) as supported [\#1337](#1337) (@rytilahti)
- Add pyupgrade to CI runs [\#1329](#1329) (@rytilahti)
@rytilahti rytilahti mentioned this pull request Mar 7, 2022
rytilahti added a commit that referenced this pull request Mar 7, 2022
This release fixes zhimi.fan.za5 support and makes all integrations introspectable for their supported models.
For developers, there is now a network trace parser (in devtools/parse_pcap.py) that prints the decrypted the traffic for given tokens.

The following previously deprecated classes in favor of model-based discovery, if you were using these classes directly you need to adjust your code:
* AirFreshVA4 - use AirFresh
* AirHumidifierCA1, AirHumidifierCB1, AirHumidifierCB2 - use AirHumidifier
* AirDogX5, AirDogX7SM - use AirDogX3
* AirPurifierMB4 - use AirPurifierMiot
* Plug, PlugV1, PlugV3 - use ChuangmiPlug
* FanP9, FanP10, FanP11 - use FanMiot
* DreameVacuumMiot - use DreameVacuum
* Vacuum - use RoborockVacuum

[Full Changelog](0.5.10...0.5.11)

**Breaking changes:**

- Remove deprecated integration classes [\#1343](#1343) (@rytilahti)

**Implemented enhancements:**

- Add PCAP file parser for protocol analysis [\#1331](#1331) (@rytilahti)

**Fixed bugs:**

- Fix bug for zhimi.fan.za5 resulting in user ack timeout [\#1348](#1348) (@saxel)

**Deprecated:**

- Deprecate wifi\_led in favor of led [\#1342](#1342) (@rytilahti)

**Merged pull requests:**

- Make sure miotdevice implementations define supported models [\#1345](#1345) (@rytilahti)
- Add Viomi V2 \(viomi.vacuum.v6\) as supported [\#1340](#1340) (@rytilahti)
- Mark Roborock S7 MaxV \(roborock.vacuum.a27\) as supported [\#1337](#1337) (@rytilahti)
- Add pyupgrade to CI runs [\#1329](#1329) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found an unsupported model 'zhimi.fan.za5' for class 'FanZA5'
1 participant