-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement push notifications for gateway #1459
Implement push notifications for gateway #1459
Conversation
@rytilahti this is the follow-up PR for the push server implementation for the gateway. |
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
- Coverage 83.35% 82.48% -0.88%
==========================================
Files 139 140 +1
Lines 13670 13897 +227
Branches 3248 3304 +56
==========================================
+ Hits 11395 11463 +68
- Misses 2057 2214 +157
- Partials 218 220 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
again a unrelated test failure about the utils module |
@rytilahti could you add this to the 5.12 milestone? |
Yeah, 3.11-dev checks on mac and windows are flaky, maybe I should disable them altogether :-( |
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
Co-authored-by: Teemu R. <tpr@iki.fi>
…/python-miio into gateway_push_server
@rytilahti thank you very much for the review and the feedback! (I am away this weekend so won't be able to work on this after tonight, if you have further suggestions, feel free to just make commits and merge the commits in this PR) |
* Renamed the file to use correct extension * Fixed the link to obtaining event information * Marked code block to use yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the docs a bit but I suppose this is otherwise fine for now, let's get it merged! Thanks @starkillerOG!
@rytilahti thank you very much for your help and suggestions, very glad we manged to get this merged before the new release :) |
Implement push server for the gateways.
Split out from PR #1288
Follow up of PR #1446
Test script: