Add missing functools.wraps() for @command decorated methods #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes defined methods show a proper function signature instead of the repr of the wrapper. Example: <function miio.click_common.DeviceGroup.Command.__call__.<locals>._autodetect_model_if_needed.<locals>._wrap(self, *args, **kwargs)> becomes <function miio.integrations.vacuum.roborock.vacuum.RoborockVacuum.status(self) -> miio.integrations.vacuum.roborock.vacuumcontainers.VacuumStatus>
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 140 140
Lines 13907 13908 +1
Branches 3304 3305 +1
=======================================
+ Hits 11474 11475 +1
Misses 2214 2214
Partials 219 219
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes defined methods show a proper function signature instead
of the repr of the wrapper.
Example:
<function miio.click_common.DeviceGroup.Command.__call__.<locals>._autodetect_model_if_needed.<locals>._wrap(self, *args, **kwargs)>becomes
<function miio.integrations.vacuum.roborock.vacuum.RoborockVacuum.status(self) -> miio.integrations.vacuum.roborock.vacuumcontainers.VacuumStatus>