Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Xiaomi Chuangmi Camera (chuangmi.camera.ipc013) as supported #1479

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

0x5e
Copy link
Contributor

@0x5e 0x5e commented Jul 27, 2022

almost all function works.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #1479 (26f937b) into master (a5565ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1479   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         140      140           
  Lines       13908    13908           
  Branches     3305     3305           
=======================================
  Hits        11475    11475           
  Misses       2214     2214           
  Partials      219      219           
Impacted Files Coverage Δ
miio/chuangmi_camera.py 72.45% <ø> (ø)
miio/discovery.py 48.64% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rytilahti rytilahti changed the title Add support for Xiaomi Chuangmi Camera (chuangmi.camera.ipc013) Mark Xiaomi Chuangmi Camera (chuangmi.camera.ipc013) as supported Jul 27, 2022
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @0x5e!

@rytilahti rytilahti merged commit 3c6b8dc into rytilahti:master Jul 27, 2022
@0x5e 0x5e deleted the feat/chuangmi.camera.ipc013 branch July 27, 2022 14:24
0x5e added a commit to 0x5e/python-miio that referenced this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants